search

pcengines / coreboot

github mirror of coreboot.org's master repository
http://www.coreboot.org/
GNU General Public License v2.0
73 stars 11 forks source link

pcengines/apu2: enable EHCI controller by default #479

Closed mkopec closed 3 years ago

mkopec commented 3 years ago

on apu3,4,5 and 6

Signed-off-by: Michał Kopeć michal.kopec@3mdeb.com

miczyg1 commented 3 years ago

@mkopec bios_knobs.c in apu2 mainboard directory should be updated as well to provide the right default value. Also there is no point in adding bootorder_def for apu2 since, ehci0 cannot be enabled o napu2 by the runtime ocnfig option. It is hardcoded to be disabled in coreboot. Also please clean up the changed that are not relevant to this PR (by rebasing onto release)

mkopec commented 3 years ago

I rebased the PR and applied the suggested changes. Looking at bios_knobs.c, ehcien already seems to default to 1 there:

https://github.com/pcengines/coreboot/blob/b4110c773709f55e8369a2f03a14a49ec4e9e269/src/mainboard/pcengines/apu2/bios_knobs.c#L259

miczyg1 commented 3 years ago

@mkopec looks good. Although the target branch is not correct. Either it should be develop or release_v4.14.0.x