search

pcfens / RaspberryPi-AS3935

A basic library for working with the AS3935 that's connected to the Raspberry Pi.
Other
52 stars 24 forks source link

Add method to display LCO on interrupt pin #16

Closed merlinmb closed 9 years ago

merlinmb commented 9 years ago

Added ability to toggle register to RPi_AS3935.py to ouput LCO frequency to IRQ (Interrupt) pin

pcfens commented 9 years ago

Thanks for the PR. Before I merge it, could you try and add a get method and convert tabs to 4 spaces (so that things conform to pep8)? Let me know if you need any help.

merlinmb commented 9 years ago

will attempt replacing tabs with spaces.

pcfens commented 9 years ago

You shouldn't have to create a new PR if you don't want to - editing the existing commits and squashing should take care of it.

merlinmb commented 9 years ago

Yeah - I see its failing on the compile after a PR.

Perhaps it's time I bought a guide to Git and refrained from PR's until I practice a bit.

On 20 Jan 2015, at 23:48, Phil Fenstermacher notifications@github.com wrote:

You shouldn't have to create a new PR if you don't want to - editing the existing commits and squashing should take care of it.

\ Reply to this email directly or view it on GitHub.

pcfens commented 9 years ago

There's a free one that helped me a lot called Pro Git.

In this case you probably want to rebase (I've done a little minor patching, getting ready to do some major test patching). then make your changes again. It's not too hard to do, just a matter of getting the right commands put together for your setup.