search

pcfens / puppet-yas3fs

Manage yas3fs with puppet.
4 stars 6 forks source link

Update README.md, fix dependency issue, Comment why can't remove pip package cleanly #7

Closed mojibake-umd closed 3 years ago

mojibake-umd commented 3 years ago

Just noticed that previous pull request was accepted. Did not expect that... Actually trying to make sure the pip install package is removed first does not work. This acknowledges that.

pcfens commented 3 years ago

Thanks for fixing the module up - it's probably pretty obvious that I don't do much with it anymore. Even though I don't have time to update it myself I'm always happy to accept PRs for it for others that still use it.

It's not letting me merge in your comments because of a conflict. I'm guessing a rebase will take care of things though if you can.

Thanks again!

mojibake-umd commented 3 years ago

@pcfens

Thanks... Merge should be clean now.

mojibake-umd commented 3 years ago

Marked work in progress. Realized I need to fix a dependency issue.

mojibake-umd commented 3 years ago

OK to merge now.

mojibake-umd commented 3 years ago

If code updates are required to make new version release to Puppet forge, let me know and I can attempt to work later. Forge probably want modules to be PDK ready going forward. Just learning PDK myself.

pcfens commented 3 years ago

The pdk convert command worked fine, but I didn't take the time to fix the Ruby code so the Rubocop stuff would pass. I uploaded the converted command to the forge as v0.4.0 too. Thanks a ton for your help.