search

pcfens / puppet-yas3fs

Manage yas3fs with puppet.
4 stars 6 forks source link

WIP: Add python3 and virtual environment support #8

Open mojibake-umd opened 2 years ago

mojibake-umd commented 2 years ago

Provides support for python3 and installing yas3fs into virtual environment,
as to not conflict with system python which maybe managed by vendor pip packages.

I have tested on RHEL7 and RHEL8. I worked on this and then let it sit for a while, but it has been running on
a dev RHEL7 machine for a while now. I think it is ready for some wider testing.

Please provide some feedback. I will try not to push any breaking changes, but it does not hurt to point to a commit id,
if you do not want anything to break on your systems.

pcfens commented 1 year ago

This looks great - as you might have guessed based on the recent updates I don't use yas3fs anymore, but am happy to merge this and upload it to the forge. Based on your todo it looks like I should probably wait until after the rEADME is updated too. If there's anything I can help with just let em know and I'm happy to. Thanks again!

mojibake-umd commented 1 year ago

@pcfens Thanks for the feedback. Busy with other tasks as work (Use this in production deployment, so this is work stuff). But I will see if I can update some Readme and documentation by the end of November, and maybe by that time others can provide some feedback. I tried to keep compatibility but some times need to move on. May need to bump major version 1.0.0 to reflect some breakage. I need to review myself what I wrote.

mojibake-umd commented 1 year ago

Updated documentation and README.md. @pcfens I bumped version to 1.0.0. you can decide if you think that is appropriate or not. Feel free to remove WIP and merge when you feel comfortable.