pcgeek86 / PSGitHub

This PowerShell module contains commands to manage GitHub through its REST API.
MIT License
182 stars 39 forks source link

Add AppVeyor CI test/build process - Fixes #16 #18

Closed PlagueHO closed 8 years ago

PlagueHO commented 8 years ago

Bug Fixes

environment:
  PowerShellGalleryApiKey:
    secure: <ToDo>

Improvements / Enhancements

Thanks!

pcgeek86 commented 8 years ago

@PlagueHO Thanks for the PR! I left a couple comments, so when you have a chance, please have a look at them.

PlagueHO commented 8 years ago

I'll make the changes and recommit tomorrow! Thanks for reviewing :smile:

pcgeek86 commented 8 years ago

@PlagueHO Thanks! If you'd like help with anything, we can always hop on Skype, too. pcgeek86 :smile:

PlagueHO commented 8 years ago

@pcgeek86 ! Cool - Good idea about skype too. I'll get it reinstalled. I've got an MS Exam in a couple of days so I'll be a bit quiet on the commit front but back after Thursday (NZDT).

I've made all the changes and also made some code layout changes to try and keep the line length to under 100 chars.

pcgeek86 commented 8 years ago

Thanks @PlagueHO -- I'll merge this! Couple of questions though:

  1. Can we completely avoid the use of global variables?
  2. A lot of people dislike the backticks (line continuation character), although functionally, it's perfectly fine. Do you use PowerShell Splatting much? That is a nice work-around to using line continuation, and enforcing the use of named parameters.
pcgeek86 commented 8 years ago

@PlagueHO Your code worked perfectly!!! Just ran a build and it's up to 0.13.1 now, thanks to your AppVeyor integration! Thanks so much for this contribution. :smile:

PlagueHO commented 8 years ago

Cool! :smile: A pleasure. I intend on getting some more commits in once I've caught up on some other issues I need to work through.

Cheers!