search

pcgeek86 / PSGitHub

This PowerShell module contains commands to manage GitHub through its REST API.
MIT License
182 stars 39 forks source link

Added support for managing release assets #33

Closed nicholasdille closed 6 years ago

nicholasdille commented 7 years ago

Hi @pcgeek86,

I have implemented handling GitHub release assets for a project of mine and thought this might look nice in your module ;-)

I have added the following cmdlets:

To support this, it was necessary to update Invoke-GitHubApi to support upload.github.com for API calls.

pcgeek86 commented 7 years ago

Thanks for these submissions @nicholasdille. I need to do some work on my side before I put more effort on this project. I'll do some research and hopefully circle back and merge this in.

Edit: Just submitted a ticket internally to see if I can get this merged.

pcgeek86 commented 6 years ago

Do we need to add these new functions to the module manifest?

nicholasdille commented 6 years ago

Yes, adding and removing release assets should be exposed to the user. I am very actively using those functions for continuous delivery of my PowerShell modules. I would love to import them from your module :-)

pcgeek86 commented 6 years ago

@nicholasdille cool, would you be interested in submitting a PR to add them to the manifest as well?

nicholasdille commented 6 years ago

This should have taken care of the module manifest

pcgeek86 commented 6 years ago

Thanks @nicholasdille! Much appreciated.