W3C tests don't pass - Githubissues

pchampin / sophia_rs

Sophia: a Rust toolkit for RDF and Linked Data

Other

217 stars 23 forks source link

W3C tests don't pass #3

Closed MarcAntoine-Arnaud closed 5 years ago

MarcAntoine-Arnaud commented 5 years ago

failures:

---- parser::nt::test::w3c_test_suite stdout ----
thread 'parser::nt::test::w3c_test_suite' panicked at 'rdf-tests/ntriples not found, can not check W3C test-suite', sophia/src/parser/nt.rs:597:17
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- parser::nt::test::w3c_test_suite_generalized stdout ----
thread 'parser::nt::test::w3c_test_suite_generalized' panicked at 'rdf-tests/ntriples not found, can not check W3C test-suite', sophia/src/parser/nt.rs:632:17

Who to get w3c_test_suite ?

MarcAntoine-Arnaud commented 5 years ago

Thks @pchampin

pchampin commented 5 years ago

Sorry, this was indeed lacking proper documentation.

This "fix" is minimalist: you have to manually follow the instructions in the README. If you have ideas to automate this process in a portable way, feel free to reopen the issue.

MarcAntoine-Arnaud commented 5 years ago

Hi,

It's a first step. I wanna to purpose soon the ability to define a build.rs file (used by Cargo) to define some function. And here we can be able to download W3C files (with a local cache for offline developments).

But before doing that I wanna to improve the code quality:

add Travis CI to test on multi versions of rust
check Rust code format
check Rust code with Clippy (to prevent some bad writing)

I have configured that on yaserde and it's cool to open source contribution.

MarcAntoine-Arnaud commented 5 years ago

I started to create a branch to test CI. In fact I used the git submodule to retrieve rdf-tests.