search

pchampin / sophia_rs

Sophia: a Rust toolkit for RDF and Linked Data
Other
214 stars 23 forks source link

Introduce TermError #30

Closed MattesWhite closed 4 years ago

MattesWhite commented 4 years ago

This PR starts the process of gradually removing error-chain from sophia as suggested in #8.

It starts by moving errors related to the creation of terms to an own sophia::term::TermError.

Temporary, a impl From<TermError> for Error was done in order to not have to refactor ParserError as well.

BTW @pchampin great work removing the lifetimes 👍

pchampin commented 4 years ago

Great PR :+1: , but... bad timing :-/ I was myself working on the parser module, which created some conflicts...

This should not be to hard to fix, though, since

pchampin commented 4 years ago

Looking good! For keeping the history clean, would you mind submitting a new PR rebased on top of master, either with rebase -i or maybe just a single commit with all your changes (they are focused enough)... Sorry for the trouble...

MattesWhite commented 4 years ago

As far as I know you can select to squash and merge a PR which squashes all commits of the PR into a single one.

Further reading:

pchampin commented 4 years ago

Good idea. I am not sure how/if it works when the PR has intermediate merges, but it's worth a try.