Closed MattesWhite closed 4 years ago
Great PR :+1: , but... bad timing :-/ I was myself working on the parser module, which created some conflicts...
This should not be to hard to fix, though, since
nt.rs
is now the old rio_nt.rs
, which you didn't touchrio_common.rs
is now calling the unchecked constructors (Rio does the checking) so no TermError handling is required there anymore.Looking good!
For keeping the history clean, would you mind submitting a new PR rebased on top of master, either with rebase -i
or maybe just a single commit with all your changes (they are focused enough)... Sorry for the trouble...
As far as I know you can select to squash and merge a PR which squashes all commits of the PR into a single one.
Further reading:
Good idea. I am not sure how/if it works when the PR has intermediate merges, but it's worth a try.
This PR starts the process of gradually removing
error-chain
fromsophia
as suggested in #8.It starts by moving errors related to the creation of terms to an own
sophia::term::TermError
.Temporary, a
impl From<TermError> for Error
was done in order to not have to refactorParserError
as well.BTW @pchampin great work removing the lifetimes 👍