Closed MattesWhite closed 4 years ago
Thanks for this proposal. Comments below
Most (if not all) places where Triple/Quad Sources are used (e.g. Graph::insert_all
), they are borrowed mutably. The reason for not consuming them is that some sources (especially parsers) may still carry valuable information after they have exhausted their triples (e.g. the prefix declaration they have encountered). See #45 for a discussion on that topic.
Would you mind making a new PR with only the last two items, and wait till we resolve #45 for the first one? Thanks
Reduced version committed in #46
Response to #34 commit 9a97dae .
&mut
from source in serialize 'statement' methods. Unnesessary as sources are completely consumed (see doc: 'Serialize all triples/quads').NxStringifier
type alias. Seems redundant to callNtStringifier::new_stringifier()
whenNtSerializer::new_stringifier()
does the same.NtSerializer
toNqSerializer
in nq.rs.