Minor changes to serializers

pchampin / sophia_rs

Sophia: a Rust toolkit for RDF and Linked Data

Other

214 stars 23 forks source link

Minor changes to serializers #43

Closed MattesWhite closed 4 years ago

MattesWhite commented 4 years ago

Response to #34 commit 9a97dae .

Remove &mut from source in serialize 'statement' methods. Unnesessary as sources are completely consumed (see doc: 'Serialize all triples/quads').
Remove NxStringifier type alias. Seems redundant to call NtStringifier::new_stringifier() when NtSerializer::new_stringifier() does the same.
Rename NtSerializer to NqSerializer in nq.rs.

pchampin commented 4 years ago

Thanks for this proposal. Comments below

Consuming Triple/Quad Source → I'm not entirely sure... see below.
Removing NxSerializer alias → good call, this is indeed better that way
Renaming NtX to NqX → of course, silly me :-/

Most (if not all) places where Triple/Quad Sources are used (e.g. Graph::insert_all), they are borrowed mutably. The reason for not consuming them is that some sources (especially parsers) may still carry valuable information after they have exhausted their triples (e.g. the prefix declaration they have encountered). See #45 for a discussion on that topic.

Would you mind making a new PR with only the last two items, and wait till we resolve #45 for the first one? Thanks

MattesWhite commented 4 years ago

Reduced version committed in #46