pchampin / sophia_rs

Sophia: a Rust toolkit for RDF and Linked Data
Other
214 stars 23 forks source link

[merged] Variable as own type #47

Closed MattesWhite closed 4 years ago

MattesWhite commented 4 years ago

Contribution according to the discussions in #34 and #35.

As a first step this moves variables out of Term and into an own type Variable.

Following features are implemented:


Step by step each kind of RDF term will get its own public submodule. I started with variables due to their small codebase. I think it is better to continue this process in small PRs rather then working weeks on an own branch and resolving ocuring conflicts in the end.

pchampin commented 4 years ago

Looks like cargo fmt is till unhappy...

pchampin commented 4 years ago

Somehow I managed to butcher the latest merged PR #46. Repaired with this commit.

Yuck! A rebase and a push --force would have been cleaner.

Instead, I cherry-picked the relevant commits from this PR (squashing the two fmt-related ones), and merged them in 19e854b1. You are still credited as the authors of the new commits.

Thanks for this work, I like where this is going.