Introduce Literal as an own type

MattesWhite commented 4 years ago

Final contribution to making kinds of RDF terms own types.

Previous PRs: #49 , #48 , #47

Closes: #34

Input from: #35 and previous PRs

This PR refactors sophia::term::Term's Literal variant into an own, public type and aligns its interface to the APIs of the previous PRs for other kinds of terms.

Due to its scale and decisions to discuss this is marked work-in-progress.

ToDo:

[x] Create type Literal.
[x] Refactor _literal_kind.rs into literal.rs.
[x] Integrate Literal into Term.
[x] Refactor conversion primitive types <-> literal.
[ ] Final alignment of Variable, BlankNode, Iri and Literal to provide a uniform API for terms.
- [x] Remove unsafe from all *_unchecked() methods and introduce debug_assert!().
- [x] Similar implementations of From, TryFrom, PartialEq and other convenience traits.
- [ ] ...

As always, the todo-list is my personal roadmap and is open to discussion.

MattesWhite commented 4 years ago

For me I did everything on my list is done and now the PR is ready to be merged.

If any changes are requested I'm happy to follow or discuss.

MattesWhite commented 4 years ago

One moment please I'm just doing some last minor changes myself

MattesWhite commented 4 years ago

Now I'm done :wink:

pchampin / sophia_rs

Introduce Literal as an own type #53