Closed MattesWhite closed 4 years ago
For me I did everything on my list is done and now the PR is ready to be merged.
If any changes are requested I'm happy to follow or discuss.
One moment please I'm just doing some last minor changes myself
Now I'm done :wink:
Final contribution to making kinds of RDF terms own types.
Previous PRs: #49 , #48 , #47
Closes: #34
Input from: #35 and previous PRs
This PR refactors
sophia::term::Term
'sLiteral
variant into an own, public type and aligns its interface to the APIs of the previous PRs for other kinds of terms.Due to its scale and decisions to discuss this is marked work-in-progress.
ToDo:
Literal
._literal_kind.rs
intoliteral.rs
.Literal
intoTerm
.Variable
,BlankNode
,Iri
andLiteral
to provide a uniform API for terms.unsafe
from all*_unchecked()
methods and introducedebug_assert!()
.From
,TryFrom
,PartialEq
and other convenience traits.As always, the todo-list is my personal roadmap and is open to discussion.