pchampin / sophia_rs

Sophia: a Rust toolkit for RDF and Linked Data
Other
210 stars 23 forks source link

Optimize 'Resolve<Literal>' #66

Closed MattesWhite closed 4 years ago

MattesWhite commented 4 years ago

The current implementation of impl Resolve<Literal> for IriParsed is not optimal as it allocates intermediate string(s).

This implementation uses the standard Resolve<Iri> for the literal's datatype and wraps the text as MownStr::Ref. The key for this implementation is to move it into the literal module where we can access the private fields of Literal.

pchampin commented 4 years ago

I am not a big fan of moving this particular implementation of Resolve away from all the others... Turns out that I managed to solved problem inside the _join module (619fe8e).