proper clean command - Githubissues

pchanial / pyoperators

Operators and solvers for high-performance computing.

http://pchanial.github.com/pyoperators

Other

14 stars 9 forks source link

proper clean command #17

Closed ghisvail closed 9 years ago

ghisvail commented 9 years ago

Quoting your last reply here:

Very good point about the clean, that will make my life easier. After some thoughts, since the definition of what is a clean state is already in .gitignore, I'm just using it in the clean command, which I have just committed..

This solution relies on the availability of git, which is only fulfilled if your repository is explicitly cloned. What happens if I use a source distribution from PyPI ? Or a zip tarball from Github ? The clean command should work in these cases as well.

The clean command I provided is pretty standard, I remember borrowing it from other projects.

I can provide a PR if you like ?

pchanial commented 9 years ago

You're right, currently, if we're not in a git repository, the original distutils clean command will be run, which doesn't clean much. Go ahead with the PR, but I would prefer that all the stuff happen in the run method, obeying the dry-run option. Printing what's removed would be a plus. If it's too much of a burden, don't worry, I'll do it one day.

ghisvail commented 9 years ago

If I have time, I'll make an attempt and submit a PR.

pchanial commented 9 years ago

Cool, thanks!

2014-10-10 12:47 GMT+02:00 ghisvail notifications@github.com:

If I have time, I'll make an attempt and submit a PR.

— Reply to this email directly or view it on GitHub https://github.com/pchanial/pyoperators/issues/17#issuecomment-58639985.

ghisvail commented 9 years ago

Hey Pierre, have you had time to look at the PR I sent you for this issue ?

pchanial commented 9 years ago

Hi Ghislain, I didn't manage to have a look to it, I'll do it tomorrow! Sorry about the delay!

2014-10-14 18:56 GMT+02:00 ghisvail notifications@github.com:

Hey Pierre, have you had time to look at the PR I sent you for this issue ?

— Reply to this email directly or view it on GitHub https://github.com/pchanial/pyoperators/issues/17#issuecomment-59078841.

pchanial commented 9 years ago

So I modify (and rebased) your patch on master:

make hooks.py independent of the package (I'm using it for other projects)
obey dry-run option
default on git clean if the command is available.

pchanial commented 9 years ago

I didn't ask you to modify it, since you've already helped on this issue and I didn't want to bother you with it. Thanks!