search

pchanial / pyoperators

Operators and solvers for high-performance computing.
http://pchanial.github.com/pyoperators
Other
14 stars 9 forks source link

remove optional deps #20

Closed ghisvail closed 8 years ago

ghisvail commented 9 years ago

temporary fixup for #19:

pchanial commented 9 years ago

Hi Guislain, sor some reason, your PR went under my radar. Sorry ! I'm not sure it's a good idea to remove the keyword 'install_requires' since it's used by pip to install dependencies. What's in the 'requires' keyword could go away, I guess.

ghisvail commented 9 years ago

The problem with setuptools is that it does not have the concept of optional requirements. For the packaging, I went for putting numpy, scipy and numexpr in install_requires.

PyFFTW and PyWavelets should be considered optional deps since they only add more functionality without preventing the package to be run without them. Best way to achieve this is to remove them from install_requires and just raise an ImportError if an import of the corresponding submodule is attempted.

If you're happy with this, I'll update my PR.

pchanial commented 8 years ago

I have included your PR by hand (I added mpi4py), but I gave the credits to you on the commit log message.