[API] Dissociate User ID from Auth0 User ID.

pchatard / giftlist

A Nuxt and Express web application to create and share wishlists with your loved ones.

https://giftlist-blue.vercel.app/

1 stars 0 forks source link

[API] Dissociate User ID from Auth0 User ID. #75

Closed ndureiss closed 2 years ago

ndureiss commented 2 years ago

@pchatard this PR as a proposal to fix #60, #62 and #74.

It:

add a optional description string field to List;
dissociate User id from Auth0 ones:
- id prop of User is now an UUID;
- auth0Id prop is created in User, all DB find, update, etc. are conditionned by where: { auth0Id: request.userId } clause;
- ownersIds and grantedUsersIds are array of User id prop, in consequences neither User mail nor User Auth0 ID are exposed.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pchatard/giftlist/4GZSqX61eDGXSRqdvbsyvF4yWooi
✅ Preview: https://giftlist-git-addauth0idlist-pchatard.vercel.app

ndureiss commented 2 years ago

@pchatard this PR is bringing breaking changes. If it's OK from your side please take into account it needed Auth0 Actions changes (for user creation) and a DB schema reset (I choose to not create a migration file so far we are not in production mode yet).

I can lead these two actions just merging this PR.

pchatard commented 2 years ago

Looks perfect for now! For arrays manipulating user objects (ex: ownerIds, grantedUsersIds, friends, etc), will it be possible to return an object composed of our new id and the display name ?

ndureiss commented 2 years ago

Looks perfect for now! For arrays manipulating user objects (ex: ownerIds, grantedUsersIds, friends, etc), will it be possible to return an object composed of our new id and the display name ?

I'll merge like that. I think we need to talk about this in a dedicated topic