pchois
commented
6 years ago Thank you, I'll work on commenting my code going forward. As far as the logical flow, I honestly didn't pay attention to that, I'll consider it in the future.
For the YAML I wanted to do an extra step, but I was already behind and just wanted to submit the code. I had an issue starting the server when the database.yaml file was empty, I was trying to add a condition that checked if it was empty on startup but had to go to work so I took it out. I feel the code would have been more robust had I added that condition.
Grade: Exceeds Expectations
Fantastic job taking this project on. You've effectively implemented each of the required routes in a concise and clean way. Your code is very smooth to read and interpret, as you've adapted your coding style to match the codebase you were given with ease. You also tackled the bonus YAML persistence issues well. Overall, you've mastered all of the most challenging elements of the assignment.
My one critique is that it seems like you're programming in isolation, without always thinking about how others interpret your code. Coding is very collaborative, so I encourage you to shift that thinking a bit. For example, commenting your code gives extreme clarity on what each function or block of code does to those who read through your work. Also, the logical flow of the code for others would likely not be to read through comment functions, then user, then article (which is how you've currently organized the project). Think about how those functions should logically be ordered! Again, you've done an awesome job here, and these suggestions are just tips to help you approach projects down the line. Congratulations!