pcko1 / etherscan-python

A minimal, yet complete, python API for Etherscan.io.
MIT License
408 stars 111 forks source link

Update comment to reflect actual returned value #33

Closed c-git closed 1 year ago

c-git commented 2 years ago

For addresses that have more than 10K transactions etherscan.io actually returns the first transactions that are within the start and end blocks.

If you compare the last block returned by the two links below you'll note that they are not the same, if the last 10k transactions were returned they would be the same as the end block is the same in both requests. The last block in first request that starts from block 0 is 5007989 while the last block in the second request that starts from block 5007989 is 5008401.

https://api.etherscan.io/api?module=account&action=txlist&address=0x6ddca767d731f57d90a516dd751f2aa9282b37d2&startblock=000&endblock=99999999&page=1&offset=10000&sort=asc&apikey=YourApiKeyToken

https://api.etherscan.io/api?module=account&action=txlist&address=0x6ddca767d731f57d90a516dd751f2aa9282b37d2&startblock=5007989&endblock=99999999&page=1&offset=10000&sort=asc&apikey=YourApiKeyToken

(Wanted to check the other cases where comments said last but didn't have time to find examples to determine if they also needed to be changed)