pcl-labs / browtricks-ui-components

https://browtricks-ui-components.vercel.app
0 stars 0 forks source link

4th milestone has been completed from frontend team #13

Closed kshekh closed 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
browtricks-ui-components ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 21, 2023 at 10:35AM (UTC)
CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cloudflare-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f2aa1e5
Status: ✅  Deploy successful!
Preview URL: https://44278fbe.browtricks-ui-components.pages.dev
Branch Preview URL: https://forth-milestone-04.browtricks-ui-components.pages.dev

View logs

paulchrisluke commented 1 year ago

@kshekh I am still reviewing, and need to update our figma prototype to be more clear. I will do that today. Leaving this review note for later and will let you know when we've updated the prototype to show correct interactions

LOOM VIDEO: https://www.loom.com/share/ec62b716d94840c0b94b7798035f852d

https://forth-milestone-04.browtricks-ui-components.pages.dev/pmu

When adding from template, the template preview image should show in the cards

https://forth-milestone-04.browtricks-ui-components.pages.dev/pmu-details

Is there a way to collapse the left sidebar in the pdf preview by default?
Print should open the pdf print option When clicking send PMU form, the modals are missing. You should see the send PMU form modal, and then see a review screen before sending. See image Mobile view needs work, pdf preview is not responsive

https://forth-milestone-04.browtricks-ui-components.pages.dev/pmu

When making your own form there are some bugs:


  1. Uploaded image thumbnail is not showing once you hit save (see 14.1 PMU Forms add a form)
  2. Adding a new question via the + icon should scroll you down to the new question you have just added, it should allow many questions to be added, not just one
  3. Hitting delete deletes all content, not just the question or option
  4. Save and create form should show the slipover from 14.1 PMU FORMS ADD A FORM in designs
bamboochow commented 1 year ago

Form Builder

  1. Hide "Image Upload" icons in question-type form building
  2. Replace trashcan icons next to text input with X icons instead
  3. Remove "or add other" from the "add option" text button

image

Update Page Linking

We are changing the steps of the "Send PMU Form" process. See Prototype: https://www.figma.com/proto/kwIHq0NTQUDBryrkZVN1ap/browtricks-cms?page-id=915%3A1500&node-id=915%3A3072&viewport=6655%2C-1582%2C0.57&scaling=min-zoom&starting-point-node-id=915%3A2750

  1. Users click "Send PMU Form" button
  2. "Send PMU Form" popup appears
  3. "Form Sent" popup appears.
  4. "View Form" Button redirects to "View Forms" page

Screenshots below are in order of the steps above: image image image image

kshekh commented 1 year ago

@paulchrisluke @giteshk11 @bamboochow We are still working on the issues and it can be taken a couple of days... maybe we will deliver by tomorrow 19th Jan,