Milestone first hes been pushed and we're still working on couple of …

pcl-labs / browtricks-ui-components

https://browtricks-ui-components.vercel.app

0 stars 0 forks source link

Milestone first hes been pushed and we're still working on couple of … #6

Closed kshekh closed 1 year ago

kshekh commented 1 year ago

…things

netlify[bot] commented 1 year ago

Deploy Preview for chipper-lollipop-fb6701 ready!

Name	Link
Latest commit	bf597fe01f4407e34d3fddf430022708f7bcdff4
Latest deploy log	https://app.netlify.com/sites/chipper-lollipop-fb6701/deploys/639364642c1b3f00093c7f79
Deploy Preview	https://deploy-preview-6--chipper-lollipop-fb6701.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

CLAassistant commented 1 year ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

cloudflare-pages[bot] commented 1 year ago

Deploying with Cloudflare Pages

Latest commit:	`bf597fe`
Status:	✅ Deploy successful!
Preview URL:	https://17cd7c81.browtricks-ui-components.pages.dev

View logs

giteshk11 commented 1 year ago

Validations need to active only when a user has clicked inside the field.

kshekh commented 1 year ago

@giteshk11 I've got your changes and will fix and update the issues. Thank you very much.

giteshk11 commented 1 year ago

I saw your comments, where is the updated code?

kshekh commented 1 year ago

I have pushed the code with new updates here https://github.com/pcl-labs/browtricks-ui-components/pull/8 Please check and share your updates or feedback. Thanks

giteshk11 commented 1 year ago

Why have you opened a new PR? I asked you update the same one on which you are working on

kshekh commented 1 year ago

Kaze suggested me to create new one "So whenever you are working on an issues you need to create a branch for that for e.g. if you are working on issue no.5 you can create a branch issue-5-whatever-the-feature-you-are-working-on"

giteshk11 commented 1 year ago

It seems like you are getting confused somewhere The issues you work on will have only one branch and one pr only e.g. if you are working on issue no 1. it's going to have only one branch and PR until all the reviews are completed and it's merged into the main branch

kshekh commented 1 year ago

Okay, I got it... Sorry for this one. What should I need to do right now?

giteshk11 commented 1 year ago

That's ok for now, just make sure for next issues you don't do it this way.

Thanks

kshekh commented 1 year ago

Okay, I will aware and it will not be repeated next time. Thanks

joeelia commented 1 year ago

I dont care that this has comments. Its too confusing to have multiple PRs. Deleting this.

pcl-labs / browtricks-ui-components