pclubiitk / IITK-Mail-Client

Developing a Mail Client for the IITK Campus Community that would be available across various platforms including Android, iOS, Windows, Web, Linux and Mac
MIT License
3 stars 17 forks source link

UI on Desktop #42

Closed bmerchant22 closed 4 months ago

bmerchant22 commented 5 months ago

We need to have a conditional rendering based on the screen size, majorly in the email list page. It looks good on the phone, but on desktop, we need quite different UI. You can take inspiration from gmail for the same.

KrishJain256 commented 5 months ago

i can start working on this

bmerchant22 commented 5 months ago

i can start working on this

I have assigned this issue to you, share the ss on the discord channel and then add the PR

KrishJain256 commented 5 months ago

i will be done by today eod mostly

KrishJain256 commented 5 months ago

@bmerchant22 I am done with the desktop UI ( width > height for now, so same UI is for tablets ) Can you check if these pages look proper so I can put a PR Screenshot from 2024-07-03 16-22-54 Screenshot from 2024-07-03 16-25-03 Screenshot from 2024-07-03 16-25-30 Screenshot from 2024-07-03 16-26-12 Screenshot from 2024-07-03 16-26-32 Screenshot from 2024-07-03 16-26-47

KrishJain256 commented 5 months ago

@bmerchant22 also, the attachment functionality isnt working. It gives the following error Screenshot from 2024-07-03 16-28-29

KrishJain256 commented 5 months ago

@bmerchant22 There is a slight change in the directory structure. I have created different files for the Desktop UI. We can choose to merge them too ( I kept it this way so to keep the code readable and short ) Screenshot from 2024-07-03 16-31-04

yashlm commented 4 months ago

@bmerchant22 I am done with the desktop UI ( width > height for now, so same UI is for tablets ) Can you check if these pages look proper so I can put a PR Screenshot from 2024-07-03 16-22-54 Screenshot from 2024-07-03 16-25-03 Screenshot from 2024-07-03 16-25-30 Screenshot from 2024-07-03 16-26-12 Screenshot from 2024-07-03 16-26-32 Screenshot from 2024-07-03 16-26-47

you can keep the drawer tabs like the inbox, sent, trash on display permanently...like its there in the webmail....you can also reduce the width of the list where it shows all the mails to make it look more compact...you can make the design the rest of the things similar to webmail as well

yashlm commented 4 months ago

@bmerchant22 There is a slight change in the directory structure. I have created different files for the Desktop UI. We can choose to merge them too ( I kept it this way so to keep the code readable and short ) Screenshot from 2024-07-03 16-31-04

it's better to keep them separate..so its fine

KrishJain256 commented 4 months ago

@yashlm Also, do i make the drawer tabs permanent for only the desktop screen ( and not the tablets ).

yashlm commented 4 months ago

@yashlm Also, do i make the drawer tabs permanent for only the desktop screen ( and not the tablets ).

yes

KrishJain256 commented 4 months ago

@yashlm done with the separate Desktop UI. I haven't applied the permanent drawer on the Advanced Settings page. The Tablet UI does not have a permanent drawer. Also, the attachment error has been resolved now. Screenshot from 2024-07-05 17-17-22 Screenshot from 2024-07-05 17-18-57 Screenshot from 2024-07-05 17-19-19 Screenshot from 2024-07-05 17-19-50

KrishJain256 commented 4 months ago

@yashlm The desktop files are also separated from the tablet ones causing a similar change in the directory structure as last time Do I put a PR ?

yashlm commented 4 months ago

@yashlm done with the separate Desktop UI. I haven't applied the permanent drawer on the Advanced Settings page. The Tablet UI does not have a permanent drawer. Also, the attachment error has been resolved now. Screenshot from 2024-07-05 17-17-22 Screenshot from 2024-07-05 17-18-57 Screenshot from 2024-07-05 17-19-19 Screenshot from 2024-07-05 17-19-50

implement it in advance settings as well...the application will seem more consistent that way...apart from this...the file structure and the other things seems good...you can put a pr

KrishJain256 commented 4 months ago

Done :+1: