Closed bmerchant22 closed 4 months ago
i can start working on this
i can start working on this
I have assigned this issue to you, share the ss on the discord channel and then add the PR
i will be done by today eod mostly
@bmerchant22 I am done with the desktop UI ( width > height for now, so same UI is for tablets ) Can you check if these pages look proper so I can put a PR
@bmerchant22 also, the attachment functionality isnt working. It gives the following error
@bmerchant22 There is a slight change in the directory structure. I have created different files for the Desktop UI. We can choose to merge them too ( I kept it this way so to keep the code readable and short )
@bmerchant22 I am done with the desktop UI ( width > height for now, so same UI is for tablets ) Can you check if these pages look proper so I can put a PR
you can keep the drawer tabs like the inbox, sent, trash on display permanently...like its there in the webmail....you can also reduce the width of the list where it shows all the mails to make it look more compact...you can make the design the rest of the things similar to webmail as well
@bmerchant22 There is a slight change in the directory structure. I have created different files for the Desktop UI. We can choose to merge them too ( I kept it this way so to keep the code readable and short )
it's better to keep them separate..so its fine
@yashlm Also, do i make the drawer tabs permanent for only the desktop screen ( and not the tablets ).
@yashlm Also, do i make the drawer tabs permanent for only the desktop screen ( and not the tablets ).
yes
@yashlm done with the separate Desktop UI. I haven't applied the permanent drawer on the Advanced Settings page. The Tablet UI does not have a permanent drawer. Also, the attachment error has been resolved now.
@yashlm The desktop files are also separated from the tablet ones causing a similar change in the directory structure as last time Do I put a PR ?
@yashlm done with the separate Desktop UI. I haven't applied the permanent drawer on the Advanced Settings page. The Tablet UI does not have a permanent drawer. Also, the attachment error has been resolved now.
implement it in advance settings as well...the application will seem more consistent that way...apart from this...the file structure and the other things seems good...you can put a pr
Done :+1:
We need to have a conditional rendering based on the screen size, majorly in the email list page. It looks good on the phone, but on desktop, we need quite different UI. You can take inspiration from gmail for the same.