pclubiitk / pclub.in

Jekyll-based repository for the Programming Club website
http://pclub.in
32 stars 72 forks source link

Added Coordinators 2022-23 #122

Closed 7shivamx closed 2 years ago

7shivamx commented 2 years ago

There are unnecessary changes. Please fix the following:

  • [ ] Undo canonical url change from https://pclub.in to http://0.0.0.0:8080.
  • [ ] Undo date changes in posts which were already published.

Made the requested changes. Kindly have a look at the changes and let me know if anything needs to be changed

adarshaj commented 2 years ago

Oh wait, you made changes to gh-pages branch? I don't think we need to touch there, we just modify the master branch. It will get built and deployed? I'm not aware of latest process to deploy...

May be one of recent ex-co-ordinators need to cross check. /cc @namangup @SomTambe @dryairship

For reference, here are previous PR on adding new co-ordinators.. #120 #106

SomTambe commented 2 years ago

@adarshaj yeah afaik changes have to be done on master branch, gh-pages gets automatically generated by github pages while building and deploying. you don't have to touch the gh-pages branch.

namangup commented 2 years ago

@adarshaj @SomTambe We are using travis as CI/CD which has recently migrated from travis-ci.org to .com breaking old CI integrations. That apparently needs some org owner rights which I don't have, I'm planning to get GitHub actions added instead.

adarshaj commented 2 years ago

@namangup - made you the org owner, since you are the coordinator. now you should have all the privileges there is.