Add post on valid Open Source contributions

pclubiitk / pclub.in

Jekyll-based repository for the Programming Club website

http://pclub.in

32 stars 72 forks source link

Add post on valid Open Source contributions #58

Closed milindl closed 7 years ago

milindl commented 7 years ago

I'm unsure whether the title is the best. But seems OK.

yashsriv commented 7 years ago

Could you please amend the commit message:

Write your commit message in the imperative: "Fix bug" and not "Fixed bug" or "Fixes bug." This convention matches up with commit messages generated by commands like git merge and git revert.

From Good Commit Messages

yashsriv commented 7 years ago

Also I get 404 for https://github.com/AP-whitehat

milindl commented 7 years ago

@yashsriv Fixed.

On another note, see https://secure.phabricator.com/book/phabflavor/article/writing_reviewable_code (the last part of the Commit Messages section). Interesting. 80 character limit < better message. But this discussion can take place later.

yashsriv commented 7 years ago

@milindl AP-whitehat url still not fixed

sakshamsharma commented 7 years ago

Also add image of the tshirts :smile:

milindl commented 7 years ago

@yashsriv thanks for the review, I'd only fixed the name! @sakshamsharma okay

pallavagarwal07 commented 7 years ago

Everything seems fine. Merging

milindl commented 7 years ago

Two things:

The "preview" of the post (on the homepage) is incorrect; anyway to fix that?
GitHub markdown turns https://li.nk to links automatically, but the site does not, this is an easy fix

yashsriv commented 7 years ago

Jekyll offers a feature to specify the excerpt separator: Link.
For the links just surrounding with box brackets should be enough

P.S. You should have built the site and tested it. P.P.S. We should have also done that 😝