search

pclubuiet / website

Programming club, PU official website.
https://pclubuiet.herokuapp.com
GNU General Public License v3.0
14 stars 70 forks source link

Add Docker Compose instructions. #136

Closed blackpioter closed 6 years ago

blackpioter commented 6 years ago

Fixes issue #135 Changes: README.md

blackpioter commented 6 years ago

@divyam3897 can you explain why white characters should be restored at EOL ?

divyam3897 commented 6 years ago

They should not be but that should not be done in this PR, you can create another issue for the same first and then it can be another beginner friendly issue for someone finding their first issue :)

blackpioter commented 6 years ago

@divyam3897 I've updated PR according to your requirements.

blackpioter commented 6 years ago

@divyam3897 have you checked the changes you requested?

divyam3897 commented 6 years ago

also as a general practice you should never work in master, please follow the README.

blackpioter commented 6 years ago

@divyam3897 I'll close this PR and open a new one.