search

pcman-bbs / pcmanx

GTK version
GNU General Public License v2.0
79 stars 74 forks source link

Strip the title if its length is larger than 20 characters. #56

Closed munhouiani closed 9 years ago

munhouiani commented 9 years ago

If the title of an opened tab is too long, it will not be shown within a tab. Instead, it shows all the characters of the title and mess with the other tab title. Please see the following picture for a better problem description.

http://i.imgur.com/MPPosvb.png

This commit first checks if the the length of a title is longer than 20 characters. If so, it will shrink the title into 17 characters and add '...' at the end, 20 characters in total.

http://i.imgur.com/k8VggEN.png

jserv commented 9 years ago

Any chance to rework this patch?

jserv commented 9 years ago

We usually call it "shrink" rather than "strip" for string manipulations.

munhouiani commented 9 years ago

@jserv Thanks! I can't recall the term "shrink" that day I sent this pull request. Will improve the commit message and send request again.

jserv commented 9 years ago

You can always use git commit --amend to modify your commits. Please check "git commit --help".

munhouiani commented 9 years ago

@jserv I changed the commit message. Please review.

jserv commented 9 years ago

Can you create a new GIT branch and send pull request again. Otherwise, the old GIT commits confuse me.