Migrating from GTK+ 2.x to GTK+ 3

pcman-bbs / pcmanx

GTK version

GNU General Public License v2.0

79 stars 74 forks source link

Migrating from GTK+ 2.x to GTK+ 3 #7

Open kidwm opened 10 years ago

kidwm commented 10 years ago

https://developer.gnome.org/gtk3/stable/gtk-migrating-2-to-3.html

Ref: https://code.google.com/p/pcmanx-gtk2/issues/detail?id=61

yan12125 commented 7 years ago

cmchao's branch at https://github.com/pcman-bbs/pcmanx/tree/gtk3 is quite old, so I re-port it and push to https://github.com/yan12125/pcmanx/tree/wip-gtk3. There are still some critical issues:

~~The term is not always correctly repainted~~ Partially fixed.
~~segfault with the site list dialog~~ Fixed.

Other minor bugs:

Site list dialog is too small
~~Icon disappears from several places, includig the About dialog~~ Fixed by re-implmenting both dialogs

PS: This is the first time I play with GTK+

yan12125 commented 7 years ago

Hmm, is https://github.com/pcman-bbs/pcmanx/tree/gtk3 really gtk3 ready? It still compiles with gtk2, and an error occurs if forcing gtk3.

kidwm commented 7 years ago

@yan12125 I think it is not ready for GTK3 now, could you help to improving next-release which target to remove deprecated functions first?

yan12125 commented 7 years ago

I can give it a try :)

yan12125 commented 7 years ago

could you help to improving next-release which target to remove deprecated functions first?

Hi @kidwm. Sorry I'm not quite sure what should be done on the next-release branch. I pulled it and apparently it runs fine (with quite a few warnings, though). Could you give some hints?

kidwm commented 7 years ago

@yan12125 It is in the process for migrating to use GAction instead of GtkAction, so current task is to refactor and eliminate those warnings while keep all functions working.