pcman-bbs / pcmanx

GTK version
GNU General Public License v2.0
79 stars 74 forks source link

Get rid of Host key authentiction can't be established messge #92

Closed lexical closed 4 years ago

lexical commented 6 years ago

This patch can get rid of the follow message:

The authenticity of host 'ptt.cc (140.112.172.1)' can't be established.
ECDSA key fingerprint is SHA256:3rvcAywUJszX7jPzC3JkbtxqnHiApB4tuwQ3swSYmSo.
Are you sure you want to continue connecting (yes/no)?

when connecting to a BBS in the ssh mode. This message is usually of no harm in the PCMAX use case (viewing BBS sites). So skip it.

lantw44 commented 6 years ago

I am not a maintainer, but as a user of PCManX, I don't want to see this change. SSH should be secure. Users should know why they have to check the key fingerprint, and we should not make it insecure by default. If you want to use it insecurely, you can do so by putting the option in your ssh_config.

holishing commented 4 years ago

I have same concern with @lantw44 , if there is no any other reason, we may close this PR. If there is a better way to refine UI of "host key authentiction", for e.g., pop-up a dialog window about checking the key fingerprint, we should open a new PR.