pcman-bbs / pcmanx

GTK version
GNU General Public License v2.0
79 stars 74 forks source link

Let regenerated libtoolize file overwrite existing file in other environment #93

Closed holishing closed 4 years ago

holishing commented 5 years ago

For resolving error message after run ./autogen.sh again after run it before, in order to revise autotool settings and test again.

$ ./autogen.sh 
+ '[' '!' -e ChangeLog ']'
+ '[' x '!=' x ']'
+ aclocal
+ autoheader
++ uname
+ '[' Linux = Darwin ']'
+ AUTOMAKE=automake
+ libtoolize -c --automake
libtoolize:   error: './compile' exists: use '--force' to overwrite
libtoolize:   error: './depcomp' exists: use '--force' to overwrite
libtoolize:   error: './missing' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/COPYING.LIB' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/Makefile.am' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/README' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/configure.ac' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/aclocal.m4' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/Makefile.in' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/config-h.in' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/configure' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/libltdl/lt__alloc.h' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/libltdl/lt__argz_.h' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/libltdl/lt__dirent.h' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/libltdl/lt__glibc.h' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/libltdl/lt__private.h' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/libltdl/lt__strl.h' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/libltdl/lt_dlloader.h' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/libltdl/lt_error.h' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/libltdl/lt_system.h' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/libltdl/slist.h' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/loaders/dld_link.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/loaders/dlopen.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/loaders/dyld.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/loaders/load_add_on.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/loaders/loadlibrary.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/loaders/preopen.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/loaders/shl_load.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/lt__alloc.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/lt__argz.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/lt__dirent.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/lt__strl.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/lt_dlloader.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/lt_error.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/ltdl.c' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/ltdl.h' exists: use '--force' to overwrite
libtoolize:   error: 'libltdl/slist.c' exists: use '--force' to overwrite…ronment

tested environments:

lantw44 commented 5 years ago

The patch looks correct to me, but I am not a maintainer. We may be able to simplify the script by using autoreconf instead of running individual commands directly, so we don't have to remember to add --force to many different places.

By the way, the title of the commit message has length 76, but most projects keep it in 72.

kidwm commented 5 years ago

@lantw44 I already invited you to join the team, please help to contribute 😃

holishing commented 4 years ago

Any news or alternative review procedure? Thanks!

kidwm commented 4 years ago

@holishing thanks for your contribution, let's merge it