search

pcolby / bipolar

Free your data from Polar FlowSync
GNU General Public License v3.0
115 stars 16 forks source link

Tests failing under Qt 5.5 #56

Closed pcolby closed 8 years ago

pcolby commented 8 years ago

Not sure why yet. See, for example, https://ci.appveyor.com/project/pcolby/bipolar/build/restructure-26/job/spkm1e7yi2k3dn9r

pcolby commented 8 years ago

See also https://forum.qt.io/topic/57883/qcompare-failing-for-doubles-on-qt-5-5-only

pcolby commented 8 years ago

So I've found the cause... in short, Qt 5.5 converts float/double QVariant objects to strings more accurately now - https://github.com/qtproject/qtbase/commit/8153386397087ce4f5c8997992edf5c1fd38b8db

See https://forum.qt.io/topic/57883/solved-qcompare-failing-for-doubles-on-qt-5-5-only/4 for brief description.

Now how to fix it...

pcolby commented 8 years ago

Fixed in commit 70822af (Travis CI, AppVayor).