Closed pueroman closed 8 years ago
Hi @pueroman,
If you could provide a couple of data files with Stages power meter data included, that would make development / testing much easier for me (otherwise we'll just have to do the "try this" ... "didn't quite work" ... "try this one instead" cycle, which can be quite a bit slower).
Ideally, you would provide data files that you don't mind making public (eg not a ride to/from your house?), in which case I'll include them in Bipolar's unit tests. But I can still use them for testing even if you don't want to make them public.
To provide the data files, pick / record a session on flow.polar.com, look at the session number in the URL, then find all of the files in the export directory (eg C:\Users\pueroman\AppData\Local\Polar\PolarFlowSync\export
) that match the pattern v2-users-*-training-sessions-<session-id>-*
. Either attach those files to a comment here (that will make them public), or email them to me at git at colby dot id dot au. Ideally zip them first, but it shouldn't hurt if you don't.
Also, it sometimes helps if you make the corresponding activity public on flow.polar.com, just so I can compare the Bipolar outputs against whatever flow.polar.com is saying, but that isn't necessary.
Cheers.
Hi @pueroman, I got your test data via email. Thanks :smile:
At a glance it looks good (ie it is valid Protocol Buffers data).
Hopefully I'll get a chance to play with it this weekend :smile:
Are you happy for me to include the test data in the Bipolar project's test data suite? (https://github.com/pcolby/bipolar/tree/master/test/polar/v2/testdata) That way it would be included in automated tests that run every time code is pushed to github (and when running tests locally). This isn't necessary, but does reduce the chance of whatever fixes I implement being broken some time in the future. I can still fix the issue without adding the data to the tests, so just let me know if you're happy for me to do so or not.
Cheers.
Hi, you can use the data for the tests. If possible cut off the gps data, if not it's also o.k.
Ok great. I'll leave out the *-route
data, since that's the one that includes the GPS samples, and isn't affected by the power code tweaks I'll be making.
@pueroman, this is probably fixed now... the TCX output seems right (as loaded into Strava), but I don't have access to PPT right now (not near my Windows machine) to test the HRM ouput.
I haven't yet set the HRM pedalling index, since that goes against the HRM spec. But it wouldn't be the first time PPT 5 needed something against the spec, so I'll enable that if testing shows its still needed.
If you're keen, you can test the generated TCX and/or HRM output via the unit test output files:
Or if you happen to use Windows, you can try the latest build from AppVeyor (the Windows automated build system I use for Bipolar):
I should be able to test against PPT 5 later in the week. Then I'll look at doing an official release for Windows and OSX.
Cheers.
Did a quick test with PPT 5 (release 5.41.002). Used file .../testdata/training-sessions-267510822.hrm Data not readable when importing it. Changed pedalling index to 1. Imported again. Everything fine then. Power data correct now. Seems like PPT has another bug. Cheers
Righto. I'll enable the Power Pedalling Index SMode
flag (f
) whenever the "Power Balance and Pedalling Index" field is present (ie whenever power data is present). Though of course the pedalling index value itself will always be 0 for now (since the V800 doesn't appear to support that data).
I'll enable the Power Pedalling Index SMode flag (f) whenever the "Power Balance and Pedalling Index" field is present (ie whenever power data is present).
Done. You should be able to test latest file(s) from the same URL(s). Otherwise I'll take a look on the weekend.
Cheers.
Been able to do the tests today. Everything seems to be fine now. Also compared data with tcx file in golden cheetah. No errors found.
That's great news! :smile:
I'm going to update the Flow Sync hook for issue #60 and then do a release.
When using Stages power meter instead polar or srm only one side of power (left power) is distributed. Two problems when exporting to hrm-file: