search

pcon / SalesforceApps

A collection of apps written for the Salesforce platform
GNU General Public License v2.0
36 stars 12 forks source link

getCometdURL argument mismatch #21

Open moblizeit opened 3 years ago

moblizeit commented 3 years ago

in cometd_setup the call is

var url = getCometdURL(data.conn, data.args);

whereas the signature has only one parameter as below:

function getCometdURL(conn:any) { return conn.instanceUrl + '/cometd/44.0'; }

pcon commented 3 years ago

Are you experiencing any issues because of that? Currently that method does not use any of the args and Javascript will just ignore any additional arguments passed. Because the args are not being used they were dropped from the method definition as to no have to add an eslint exception to the function declaration

moblizeit commented 3 years ago

well no issues just pointed as i use typescript and with tighter grammar rules it complains about it.