GH-34 Implements undo/redo

pcorless / icepdf

PDF Rendering and Viewing API in Java

Apache License 2.0

77 stars 21 forks source link

GH-34 Implements undo/redo #271

Closed gtache closed 7 months ago

gtache commented 1 year ago

Closes #34
Supports only annotation create, delete and move for now.

pcorless commented 1 year ago

Nice to see some very old api's working again, nice work. I managed to generate a few null pointers, but I'll get a valid test case to you so it can be addressed.

pcorless commented 7 months ago

Similar to the summary panel PR, would it be possible to avoid using com.twelvemonkeys.io.FileSeekableStream in favour of regular java.io. I don't think seekable is needed for this import and I'd rather not add another library dependency unless absolutely necessary.

gtache commented 7 months ago

I don't see where I'm using FileSeekableStream here, can you point me to it?

pcorless commented 7 months ago

weird not seeing it now either.