search

pcorliss / ruby_route_53

Ruby gem and command line tool for Amazon's Route 53 service.
blog.50projects.com
GNU General Public License v3.0
172 stars 32 forks source link

add health_id for record that have health check associated #38

Closed patrickviet closed 9 years ago

patrickviet commented 9 years ago

Hi, I was creating automatically some records and I saw this feature missing. After reading on http://docs.aws.amazon.com/Route53/latest/APIReference/API_ListHostedZones.html how it worked, I made this fork/diff.

-- Patrick

pcorliss commented 9 years ago

Looks good, I was able to do a little bit of manual testing and it seems to send the request fine. I went ahead and fixed the test failures.

The test failures should now be fixed. Two were from an rspec upgrade. The others were some sort of change in how web mock or vcr works.

Let me know if the change works for you and I'll issue a new point release to the gem.

patrickviet commented 9 years ago

If you mean the code changes - sure, it all works for me. For the rspec, not sure how to run it. I tried on my local machine to run

rake spec

and the result was

All examples were filtered out; ignoring {:focus=>true}
........**...

Pending:
  Route53::Connection#get_zones handles subqueries based on the hostedzone
    # Not yet implemented
    # ./spec/lib/route53/connection_spec.rb:22
  Route53::Connection#get_zones handles truncated responses
    # Not yet implemented
    # ./spec/lib/route53/connection_spec.rb:21

Finished in 0.12249 seconds (files took 0.44802 seconds to load)
13 examples, 0 failures, 2 pending
pcorliss commented 9 years ago

New gem v0.3.1 pushed to rubygems.