search

pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.4k stars 5.74k forks source link

move text about how to contribute into it's own doc #1001

Closed brandonmcclure closed 2 years ago

netlify[bot] commented 2 years ago

Deploy Preview for xenodochial-hugle-b9ec84 ready!

Name Link
Latest commit 5b78912c25a0634b85458cadbe87f09e9dbdf24a
Latest deploy log https://app.netlify.com/sites/xenodochial-hugle-b9ec84/deploys/6300590a096c8b0008d3f5b7
Deploy Preview https://deploy-preview-1001--xenodochial-hugle-b9ec84.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pcottle commented 2 years ago

I really appreciate the PR! but I think the downside here is that you can't view this information by immediately landing on https://github.com/pcottle/learnGitBranching, and have to find the (somewhat small) link to jump over to contributing.

I think having the high-level information on how to build the project and get going is useful in the readme -- maybe we could reserve the contributing doc for guidelines on how to format the pull request proposal (given that you really only see it when you start to make a PR).

Going to close for now but appreciate the effort!