search

pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.61k stars 5.75k forks source link

Nodes in goal over the area #1003

Closed fish-404 closed 2 years ago

fish-404 commented 2 years ago

When I use my personal notebook to visit this site, I find the top node will over the area. When I use my work computer which has bigger display, I won't meet this problem. Inspect in my notebook, find the dynamic top value is a negative. My notebook size is 15.6 in.

If I use this custom style to force the top unset, everyting is ok. 

div.canvasTerminalHolder>div.terminal-window-holder div.inside svg {
    top: unset !important;
}

screenshot

pcottle commented 2 years ago

Oh I've seen this before, would you want to submit a pull request to fix this? I think it happens consistently on shorter windows

fish-404 commented 2 years ago

Oh I've seen this before, would you want to submit a pull request to fix this? I think it happens consistently on shorter windows

But when I shorter the browser windows in a longer display, I won't see this. I'm not sure whether it should be applied.

pcottle commented 2 years ago

if you have that style applied all the time and it only fixes the bug and doesn't cause anything else, it's probably worth adding? we can always remove it if it causes another issue (and ill do a bit of testing on my end too)