search

pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.4k stars 5.74k forks source link

[Bug]: Juggling Commits #2 #1016

Closed mg901 closed 1 year ago

mg901 commented 1 year ago

Hi, Peter! Thank you for your awesome game!) If I use the command git cherry-pick C2 C3 the level is passed, but my solution is wrong.

pcottle commented 1 year ago

the goal specifically allows a >= for the c2 to c3 jump: https://github.com/pcottle/learnGitBranching/blob/main/src/levels/mixed/jugglingCommits2.js#L10-L17

which is why it works. there are edge cases in the levels where we might allow an invalid solution, but its to facilitate people solving the level in different ways

mg901 commented 1 year ago

@pcottle Ok. Thank you!)