search

pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.4k stars 5.74k forks source link

Accessibility : Inert attribute for content outside of modal #1022

Closed ulyssear closed 1 year ago

ulyssear commented 1 year ago

Part of #960

In order to contribute to the issue of zcorpan, I corrected one of the points present in the to-do list :

Content outside modal dialog boxes are not inert and so can be reached with screen readers.

.showModal() could help (or maybe the inert attribute).

In this PR, when a modal is opened, all children except .modalView have the attribute "inert" (as zcorpan suggested), which is removed when the modal is closed.

netlify[bot] commented 1 year ago

Deploy Preview for xenodochial-hugle-b9ec84 ready!

Name Link
Latest commit 7d559281c9e544314e493c30a595e328432afde5
Latest deploy log https://app.netlify.com/sites/xenodochial-hugle-b9ec84/deploys/6343cf1e0788d00009b20506
Deploy Preview https://deploy-preview-1022--xenodochial-hugle-b9ec84.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pcottle commented 1 year ago

thanks!