search

pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.4k stars 5.74k forks source link

Unable to enter commands in console on both Chome and Edge #1026

Closed noahbowman closed 1 year ago

noahbowman commented 1 year ago

Using Windows 10 - I can interact with the UI but the console does not take any input on both Chrome and Edge.

image

However, when I use Firefox I can enter commands just fine

image

The cursor is also visible in Firefox on the console, but is not visible on the other two browsers.

Firefox: image

Other: image

pcottle commented 1 year ago

This might be related to 01b11e1ac2774fc61c66dc6145f9404584f24363. Let me try reverting

pcottle commented 1 year ago

I just reverted this and I'm pushing the site now: https://github.com/pcottle/learnGitBranching/commit/e11d69148086411b4ab3e030512d569d0a262a1b

can you try after a hard refresh (clearing cache) on https://learngitbranching.js.org/?NODEMO ?

noahbowman commented 1 year ago

Yep, tested https://learngitbranching.js.org/?NODEMO on both Chome and Edge - works great! Also, checked Firefox again for good measure and that is still working OK.

Holipori commented 1 year ago

I just reverted this and I'm pushing the site now: e11d691

can you try after a hard refresh (clearing cache) on https://learngitbranching.js.org/?NODEMO ?

Hi, I'm using Safari and Chrome on Mac. I just cleared my cache and tried https://learngitbranching.js.org/?NODEMO. It works on both browsers. But the tutorial sections still don't allow me to enter anything.

dori-b9e commented 1 year ago

Pressing tab key multiple times will get your cursor back(Chrome, macOS). Maybe some hidden input element is holding the cursor?

Holipori commented 1 year ago

wow! It works. Thank you!

waldyrious commented 1 year ago

CC @ulyssear for awareness :point_up:

ulyssear commented 1 year ago

I may have found a solution and indeed, I put a code in the wrong place, which led to unintended consequences.

The code aiming to add the "inert" attribute was done via the "show" and "hide" methods present in the ModalView object, in the src\js\views\index.js file. By moving it in the "toggleShow" method, near of "stealKeyboard" and "releaseKeyboard", there is no longer any blocking on the console input. I'm going to do a PR that should solve this problem.

Anyway, sorry for that !

EDIT: The PR has been created at #1027

imarman commented 1 year ago

Pressing tab key multiple times will get your cursor back(Chrome, macOS). Maybe some hidden input element is holding the cursor?

It works, Thanks!

pcottle commented 1 year ago

(sorry for the delay, got the covid/flu shot yesterday and was quite sick)

I merged #1027 and I'll push that to production now!

pcottle commented 1 year ago

Just confirmed that the cursor no longer gets stolen for tutorials, so going to close this out

dr1ver1 commented 1 year ago

I have this issue. I've just used the site for the first time on a new computer. Windows 11 using Chrome. Pressing Tab multiple times seemed to fix it