pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.61k stars 5.75k forks source link

Premature completion of the task #1044

Closed tyurnev closed 1 year ago

tyurnev commented 1 year ago

Hi!

I found that on lesson "Juggling Commits #2" (level 4, lesson 3) if you type git checkout main and git cherry-pick C2 C3 then the task will be done, but we doesn't have the second apostrophe on C2 commit, as it's displayed in the solution:

one two

pcottle commented 1 year ago

Yeah this was done intentionally to allow a wider variety of solutions, but I just changed the assert to enforce that C2 has more amends than C3. this will make the above no longer solve the level, but prevent some other valid solutions as well (in terms of what this level is trying to teach you)

hong4rc commented 1 year ago

Please check this commit work for https://github.com/pcottle/learnGitBranching/issues/487

https://github.com/pcottle/learnGitBranching/commit/85ae115fc20da020bde4976b783d1b324b12f60f