pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.4k stars 5.74k forks source link

Level Builder hangs when trying to edit dialog #1045

Closed fk3 closed 1 year ago

fk3 commented 1 year ago

When using the level builder and trying to create a dialog, a window appears with the Buttons to add a modal view or a git demonstration view. But clicking the buttons does not do anything, not even cancel works, i.e. the edit-dialog-window basically "hangs" and I need to refresh the browser page.

Reproduction steps:

build level edit dialog

(issue is also present when actually building a level, but editing the dialog right at the start is faster to show the issue)

pcottle commented 1 year ago

Good catch! Yeah this broke when there was a migration to use button elements instead of divs, which meant some click handlers broke