search

pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.4k stars 5.74k forks source link

[Bug] Cannot pass level mixed5 in some situation #1048

Closed dong628 closed 1 year ago

dong628 commented 1 year ago

The dev output:

{"branches":{"main":{"target":"C1","id":"main","remoteTrackingBranchID":null}},"commits":{"C0":{"parents":[],"id":"C0","rootCommit":true},"C1":{"parents":["C0"],"id":"C1"}},"tags":{},"HEAD":{"target":"main","id":"HEAD"}}

Screenshot_20230110_105818 Screenshot_20230110_110014

After I created 2 commits on "side" branch and created a new branch, the level might no longer be passed.

dong628 commented 1 year ago

By the way, you are doing a very GREAT job. As they said "It is one of the best resources I found on git". Thank you for your awesome work and thank all the contributors for inproving the i18n and fix bugs, it truly shows the power of community!

pcottle commented 1 year ago

Thanks for the kind words! Yes this is because the C7 commit has not been placed below/downstream of the C6 commit.

It has to be C7 -> C6 to pass. Its c10 in this screenshot:

Screen Shot 2023-01-11 at 8 49 08 AM

vs

Screen Shot 2023-01-11 at 8 49 25 AM

Would you prefer we just look for one more commit on bugFix instead of explicitly C7?

dong628 commented 1 year ago

Yes, because both Chinese and English discriptions' meaning is that a commit on bugFix represents you are finished, rather than a commit named "C7". Thx!