search

pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.34k stars 5.73k forks source link

'Cancel' Button in the Interactive Rebase Window still results in the successful message #1058

Closed shreyas3156 closed 1 year ago

shreyas3156 commented 1 year ago

First, thank you so much for this one-of-a-kind learning experience! I have used git commands in bits and parts before, but going through the levels on this website has finally made me confident.

Issue: When navigating through the instructions in the 'Interactive Rebase' Level, the final stage of Git Demonstration opens the window with Pick and Omit options for several commits, along with the buttons 'Cancel' and 'Confirm'. learnGit2

Upon clicking the 'Cancel' button, it still shows the 'Boom! Git copied down commits..' message as shown below. learnGit3

I think the successful message can be shown when clicking the confirm button, but not with the 'Cancel' button.

pcottle commented 1 year ago

Yeah this is an unfortunate edge case, since we don't expect you to really cancel the command we are trying to teach you during the dialog. I'll see if maybe I can just disable the command button in that case.

pcottle commented 1 year ago
Screenshot 2023-02-19 at 4 40 47 PM