Closed Netz00 closed 1 year ago
Name | Link |
---|---|
Latest commit | 7a55e66b376485ec51af4bbd18e38afb9062af24 |
Latest deploy log | https://app.netlify.com/sites/xenodochial-hugle-b9ec84/deploys/645535c483f61b00082ba07f |
Deploy Preview | https://deploy-preview-1072--xenodochial-hugle-b9ec84.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Alright super close! This definitely resets the animation but I think it also prevents advancing to the next screen. When I tried it out using the green "right" arrow to advance through the lesson, I just got stuck in the loop of going to the reset button -> back to the original starting point, but I could never advance to the next part of the lesson.
I think this is because that positive
method just puts us in a loop. I think we would need to do something like this:
onResetButtonClick: () => {
this.demonstrated = false;
this.takeControl();
}
and then just wire up the button click
Yeah, sorry for that. I completely forgot to check itπ€¦π»ββοΈ. Should be fixed with the last commit. I am glad the rest is okay, and I am not sure if I should add some tests.
Looks great! Going to do two little polish things (change it to "Reset Animation" and maybe fade it out a bit) but thanks so much :D
Waiting for comment, all tests passed. I will add tests for this feature after it's approval.
Before
After: