pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.52k stars 5.75k forks source link

level 5: teamwork * should not be shown #1132

Open thenameischainbreaker opened 6 months ago

thenameischainbreaker commented 6 months ago

The level asks to clone a remote repo, but it looks like you start from a local repo already, because main has a . I was confused for a bit because other levels only the local repo could have a .

FaithfulDev commented 6 months ago

I believe the *-sign is indicating what branch you have checked out and not that it's a remote repo. That said, remote repos are usually indicated by a stroked-outline. In fact that is what it appears after you run "git clone". For example, this is how it looks after playing with it:

image

You can see the remote repo at the right side and the checked out branch "foo" with the *-sign.

That said, initially the remove repo has a solid outline and thus would appear as local. I would say that is a bug.

image

This however is just like Remote-Level-1, where you also start out with only a remote repo, just like in Remote-Level-5.

pcottle commented 6 months ago

Thanks @FaithfulDev for explaining here (and on the other issue)!

So in the starting moment on the level, this is actually your local repository that exists, so it shouldn't have the outline. You run git clone to create the remote:

Screenshot 2024-03-21 at 4 52 49 PM

Now there's been some very valid feedback that git clone only really works if a remote repo already exists, so creating a remote repo by running clone doesn't really make sense. I totally agree with that, it just would be really hard to rework all of the lessons with that update.

I'd also say that git clone is the more common command to run before you start interacting with remote repositories, since most people are cloning an existing repo. So it makes sense spiritually why thats the command you run during these lessons

Hope that explains things