Closed juanmv94 closed 2 months ago
Need to make some little fix to my changes...
Looks like all compilation issues are related to tests expecting different (incorrect) results that were addressed by the fixes. Tests might need corrections:
doesn't fetch if out of sync, but will update explicit dest if specified o/main gets updated after git fetch origin main:main but wasn't updated before correction
correctly resolves source during git fetch with params correctly resolves existing commits and updates doesn't let you fetch to main if you are checked out there Does unallowed git fetch origin foo^:blah
pulls to a new branch and then merges in that branch o/main gets updated after git pull origin main:bar but wasn't updated before correction
Yeah I totally agree that we shouldn't teach the functionality here that doesnt work (hence why I redid the lesson), but I hesitate to actually break the functionality.
There might be others relying upon this for levels in gists or with hardcoded commands, and adding the validation code might break that :/
will think on this but it seems like a lower priority item compared to updating the lesson (which we did)
Alrighty, looks like everything is passing! Appreciate all the updates here and the work @juanmv94 :)
Will merge and push
✅ Deploy Preview for xenodochial-hugle-b9ec84 ready!
Toggle QR Code...
Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site configuration.