pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.16k stars 5.72k forks source link

Fixed many fetch/pull issues on #1138 #1141

Closed juanmv94 closed 2 months ago

netlify[bot] commented 2 months ago

Deploy Preview for xenodochial-hugle-b9ec84 ready!

Name Link
Latest commit d45c7400b96027f61dd19ad9247d202a3a49a1df
Latest deploy log https://app.netlify.com/sites/xenodochial-hugle-b9ec84/deploys/662d24e126d74f00089ac182
Deploy Preview https://deploy-preview-1141--xenodochial-hugle-b9ec84.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

juanmv94 commented 2 months ago

Need to make some little fix to my changes...

juanmv94 commented 2 months ago

Looks like all compilation issues are related to tests expecting different (incorrect) results that were addressed by the fixes. Tests might need corrections:

pcottle commented 2 months ago

Yeah I totally agree that we shouldn't teach the functionality here that doesnt work (hence why I redid the lesson), but I hesitate to actually break the functionality.

There might be others relying upon this for levels in gists or with hardcoded commands, and adding the validation code might break that :/

will think on this but it seems like a lower priority item compared to updating the lesson (which we did)

pcottle commented 2 months ago

Alrighty, looks like everything is passing! Appreciate all the updates here and the work @juanmv94 :)

Will merge and push