search

pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.52k stars 5.75k forks source link

make modal draggable #1146

Closed hiroto1220 closed 4 months ago

hiroto1220 commented 4 months ago

This chage allows you to move the modal that comes up when doing an interactive rebase. I think this is useful when you want to work on a modal while looking at the goal. (ex. level2 move2)

netlify[bot] commented 4 months ago

Deploy Preview for xenodochial-hugle-b9ec84 ready!

Name Link
Latest commit e5cab6a64680d9e737a7b8c84314559492a403e8
Latest deploy log https://app.netlify.com/sites/xenodochial-hugle-b9ec84/deploys/66421220c5b5e70007c59dc2
Deploy Preview https://deploy-preview-1146--xenodochial-hugle-b9ec84.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pcottle commented 4 months ago

Awesome contribution! But I think this makes all terminal windows draggable, including the window for selecting a level and a bunch others.

Could we just do this change on ./js/views/rebaseView.js so its contained to just the interactive rebase one?

hiroto1220 commented 4 months ago

Thanks for the review! I think it would be fine if all terminal windows are draggable, such as to see Instractions while checking the current conditions.

pcottle commented 4 months ago

Hrm I wasn't able to get it to drag all the way down -- could you?

Screenshot 2024-05-13 at 7 37 40 PM

the goal window successfully can drag all the way down

hiroto1220 commented 4 months ago

I wasn't able to do it. I can do it in the local environment, but not after deployment.😕

pcottle commented 4 months ago

Yeah the draggable jQuery plugin is quite old and I wouldn't be surprised if it's buggy. I might revert this change just so we avoid any bugs but appreciate the PR anyways!