search

pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.4k stars 5.74k forks source link

Fix Korean translation #1163

Closed DAUN3046 closed 3 weeks ago

DAUN3046 commented 3 weeks ago

Fixed Korean translation to be more natural.

netlify[bot] commented 3 weeks ago

Deploy Preview for xenodochial-hugle-b9ec84 ready!

Name Link
Latest commit 9d2a1f6caa90c9cdf29b9d0262d02a67afd025a7
Latest deploy log https://app.netlify.com/sites/xenodochial-hugle-b9ec84/deploys/66c68698436d0900080ddf77
Deploy Preview https://deploy-preview-1163--xenodochial-hugle-b9ec84.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pcottle commented 3 weeks ago

@DAUN3046 you closed this merge request without the changes being incorporated into main! Would you still like to make these edits?

I don't know Korean so I can't tell if these should be included or not 😅

pcottle commented 3 weeks ago

going to try to reopen...

pcottle commented 3 weeks ago

Just copied over your changes manually @DAUN3046 since I had trouble re-opening the PR, but let me know if you want to submit a trivial change so you're officially counted as a contributor!

Thanks for the great update here 🙌🏻 I had a coworker who understands Korean review the changes and she was impressed with the quality

DAUN3046 commented 2 weeks ago

I've temporarily closed the PR due to the need for additional spelling corrections - thanks for the reflection! @pcottle