search

pcottle / learnGitBranching

An interactive git visualization and tutorial. Aspiring students of git can use this app to educate and challenge themselves towards mastery of git!
https://pcottle.github.io/learnGitBranching/
MIT License
30.6k stars 5.76k forks source link

Box for branch name extends across the entire screen #418

Closed jim-moody closed 7 years ago

jim-moody commented 7 years ago

Using Chrome on Mac OS Sierra

screen shot 2017-03-21 at 2 44 34 pm
pcottle commented 7 years ago

What version of chrome? What level is this, and did you have browser zoom enabled, and is this 100% repro or only occasional?

Lopako commented 7 years ago

+1; happens for me too, all the levels (or at least a handful of random ones I looked at + sandbox):

Chrome: Version 57.0.2987.98 (64-bit) OS: Ubuntu 14.04.1

This was not happening for me when I visited the site on March 13th.

tridentwizard commented 7 years ago

This is my issue too.

pcottle commented 7 years ago

screenshot 2017-03-22 at 7 35 46 pm would love to fix it for all of you, but I can't get a repro :-/ can anyone mess with the CSS?

Lopako commented 7 years ago

Have you updated Chrome and tried it? I just updated chrome on my PC (Windows 10) - and before I do not think it was happening, but after updating to the latest Chrome and restarting Chrome the bug happened immediately upon loading the page.

pcottle commented 7 years ago

Ahhh I see, yeah we make the box width based on the text width which calls into the browser, so something must be updated with that calculation

pcottle commented 7 years ago

yeah this is whats bananas -- it thinks this text node is 1020 pixels wide for some reason!

screenshot 2017-03-22 at 9 55 37 pm
pcottle commented 7 years ago

ill just switch to checking the bounding box...

screenshot 2017-03-22 at 9 57 35 pm
pcottle commented 7 years ago

I checked for open bugs on chromium for this but couldn't find anything... odd. Anyways, fix is being pushed to the site now!

pcottle commented 7 years ago

Done!

jim-moody commented 7 years ago

Awesome - thanks! Sorry I didn't provide more information, I wasn't checking my email.

pcottle commented 7 years ago

No worries, just glad I got a reliable repro and was able to work around it

On Thu, Mar 23, 2017 at 5:56 AM, jim-moody notifications@github.com wrote:

Awesome - thanks! Sorry I didn't provide more information, I wasn't checking my email.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/pcottle/learnGitBranching/issues/418#issuecomment-288710035, or mute the thread https://github.com/notifications/unsubscribe-auth/ABFRn3WIfa83bnxZLqCrNWk_CFc2pwbxks5romwLgaJpZM4MkPp8 .

-- Peter M Cottle UC Berkeley Class of 2012 Master's of Science, Mechanical Engineering UC San Diego Class of 2011 Bachelor's of Science, Mechanical Engineering (650) 862 3491

"Equipped with his five senses, man explores the universe around him and calls the adventure Science." - Edwin Hubble