Open awsomearvinder opened 3 years ago
Oh yeah also, add feeds for more than just the regular r/pcpartdeals subreddit. There's also buildapcsalesuk among others.
Also, I thought this was a very neat way of formatting the posts.
Huh, that is neat. I'll have to keep that one in mind.
ISSUE:
Current implementation by me in robotport is a hot mess. It works via deleting old messages and then reposting them to get that tickmark that says a new message has been posted in the channel, and it deletes the last message every time. This means it'll delete messages by other people as that was not a previous use case of the channel, not to mention it stops working sometimes.
PROPOSAL:
Bring in PRAW, and scrape r/buildapcsales as we do now. However, go back to edit functionality, and add in a new "announcement" command. This command should take an announcement and a time, and it'll automatically remove the announcement after the given time passes. 2 embeds will be posted, one with manually curated announcements and one automatic from r/buildapcsales.
Despite these two features both being used for the same concept, I propose 2 new cogs: A "Announcement" cog, and a "part sales" cog.
This is blocked by still not having a database. I badly need to get to that. With that said as it's blocking so many issues I'm fine with someone else investigating on how to achieve that too. I'll make an issue with goals and tag it here in a bit.
DRAWBACKS:
We'd need to coordinate this with robotport and remove that feature before moving forward with our implementation. As a result up until then it'll probably live in it's own branch until then even when upstreamed.
Other then that I'm not too worried as far as code complexity and the like is concerned, I don't think it's going to be that complex of an implementation.