pcrockett / kin-backup

Secure, simple backups for your next of kin
MIT License
3 stars 0 forks source link

Random small files can't be extracted in Windows #22

Closed pcrockett closed 5 years ago

pcrockett commented 5 years ago

In Windows 10:

  1. Create a kin project
  2. Add subdirectories to the public folder, put files in them
  3. Compile to a backup package
  4. Try to extract files from the public.zip in the backup package

Windows will give you an unexpected error message. Interestingly enough, files in the root of the zip archive extract just fine.

pcrockett commented 5 years ago

Not sure what's wrong. I filed an issue with zip-rs asking for help.

pcrockett commented 5 years ago

Turns out it wasn't an issue with sub-directories after all. I just got lucky and found a bug. I was testing with small files, and some small files weren't handled appropriately by one of zip-rs's dependencies, libflate.

Anyway, it'll be officially fixed in rip-rs's 0.5.1 release. I went ahead and started using the latest directly from the rip-rs Git repository. It works now.