search

pcroland / deew

Dolby Encoding Engine Wrapper
https://deew.dev
MIT License
195 stars 20 forks source link

[BUG] Unraised ffmpeg exception when wav isn't properly finished by ffmpeg #63

Open noxxusnx opened 1 month ago

noxxusnx commented 1 month ago

Description of the the bug While running deew in a Ubuntu VM, my vdisk wasn't large enough (only 25GB). So when encoding certain files, it would run out of space. However this wasn't clear because deew swallowed the real exception from FFMPEG and continued on as if it was successful. By manually running the ffmpeg step myself I was able to find the real issue. How this would end up presenting though deew would be:

  1. Run deew for a set of files
  2. ffmpeg portion runs
  3. Behind the scenes a .wav file is generated but it is incomplete because ffmpeg ran out of space to write the file
  4. deew starts the measure step
  5. Exception is thrown: 
    wav: DEE Exception: Mediainfo xml parse failed (-1).
input[0]:audio[0]:wav[0]: Input stage (input[0]:audio[0]:wav[0]) run failed.

Version deew 3.2.1

OS Ubuntu 24.04 LTS

pcroland commented 1 month ago

Isn't it just a warning which is supressed?

noxxusnx commented 1 month ago

Hmmm it may have been a warning, I remember it was highlighted in red, but I fixed the vdisk size on my VM so I can't replicate it anymore. Either way, the issue ends up suppressed when ideally deew would see that the wav has issues during its export and not use it.

pcroland commented 1 month ago

It's suppressed because ffmpeg gives out a lot of warnings even when files are fine. Maybe I'll add an option, I'll look into it.

noxxusnx commented 1 month ago

Thanks! I'm sure it would save someone else a ton of digging in the future if they did the same thing I did. At the very least having my issue documented here should at also make the error message more searchable.